From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] ixgbe: fix compilation when offload flags disabled Date: Wed, 29 Jun 2016 11:15:52 +0100 Message-ID: <20160629101552.GE4720@bricha3-MOBL3> References: <1467042269-22703-1-git-send-email-olivier.matz@6wind.com> <1569745.6sBGvsO00c@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Olivier Matz , konstantin.ananyev@intel.com, dev@dpdk.org, helin.zhang@intel.com, amint@icsi.berkeley.edu To: Thomas Monjalon Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D67FD2B8C for ; Wed, 29 Jun 2016 12:15:57 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1569745.6sBGvsO00c@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 27, 2016 at 07:05:45PM +0200, Thomas Monjalon wrote: > 2016-06-27 17:44, Olivier Matz: > > The ixgbe driver does not compile if CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=n > > because the macro has not the proper number of parameters. > > We really need to understand why this build option is needed. > Target: zero build option. Agreed. However, we are where we are right now, and this build option is there. Olivier, can you do a V2 of this patch based on dpdk-next-net/rel_16_07, since the code in question has actually moved on that branch. Out of interest, can you perhaps also give a little more detail on how to reproduce the issue, as turning off the setting fails to show up a build problem for me with either gcc or clang, at -O3 or -O0. /Bruce