From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 2/2] net/thunderx: fix unused function
 nicvf_mbox_msg_str error
Date: Wed, 29 Jun 2016 11:39:51 +0100
Message-ID: <20160629103951.GH4720@bricha3-MOBL3>
References: <1467044166-31912-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1467044166-31912-2-git-send-email-jerin.jacob@caviumnetworks.com>
 <57723BA2.6000002@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>, dev@dpdk.org,
 thomas.monjalon@6wind.com
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 3942C968
 for <dev@dpdk.org>; Wed, 29 Jun 2016 12:39:55 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <57723BA2.6000002@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 28, 2016 at 09:56:02AM +0100, Ferruh Yigit wrote:
> On 6/27/2016 5:16 PM, Jerin Jacob wrote:
> > Fix the following error with clang
> > 	error: unused function 'nicvf_mbox_msg_str'
> > 
> > The nicvf_mbox_msg_str() maybe unused, based on DEBUG
> > compilation option selected. Mark __attribute__((unused)) on
> > this function, to inform compiler that this function may be unused
> > 
> > Fixes: e93592f1 ("net/thunderx/base: add mbox APIs for PF/VF communication")
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> ...
> 
> > -static inline const char *
> > +static inline const char * __attribute__((unused))
> it is possible to use __rte_unused macro here, although not required,
> and moving it before return type can prevent checkpatch error
> 
> 
> >  nicvf_mbox_msg_str(int msg)
> >  {
> >  	assert(msg >= 0 && msg < NIC_MBOX_MSG_MAX);
> > 
> 
> Checkpatch gives following error:
> ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
> #39: FILE: drivers/net/thunderx/base/nicvf_mbox.c:67:
> +static inline const char * __attribute__((unused))
> 
> 
> check-git-log gives following errors:
> Wrong headline format:
> net/thunderx: fix unused function nicvf_mbox_msg_str error

Thanks for flagging these Ferruh. I'll fix them on apply, no need for V2, unless
you particularly want to do one, Jerin. :-)

/Bruce