From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 3/4] virtio: move SSE based Rx implementation
 to separate file
Date: Wed, 29 Jun 2016 16:57:46 +0530
Message-ID: <20160629112744.GB5301@localhost.localdomain>
References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1467028448-8914-4-git-send-email-jerin.jacob@caviumnetworks.com>
 <CAP4Qi38pZ0U5-wNGkGUagii5=xnOLG2NYuUa9toCdms0TwE87A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <dev@dpdk.org>, Thomas Monjalon <thomas.monjalon@6wind.com>, Bruce
 Richardson <bruce.richardson@intel.com>, <huawei.xie@intel.com>,
 <yuanhan.liu@linux.intel.com>
To: Jianbo Liu <jianbo.liu@linaro.org>
Return-path: <dev-bounces@dpdk.org>
Received: from na01-by2-obe.outbound.protection.outlook.com
 (mail-by2on0056.outbound.protection.outlook.com [207.46.100.56])
 by dpdk.org (Postfix) with ESMTP id 4F5A72BA7
 for <dev@dpdk.org>; Wed, 29 Jun 2016 13:28:11 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CAP4Qi38pZ0U5-wNGkGUagii5=xnOLG2NYuUa9toCdms0TwE87A@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jun 28, 2016 at 02:17:41PM +0800, Jianbo Liu wrote:
> On 27 June 2016 at 19:54, Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
> > split out SSE instruction based virtio simple rx
> > implementation to a separate file
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >  drivers/net/virtio/virtio_rxtx_simple.c     | 166 +-------------------
> >  drivers/net/virtio/virtio_rxtx_simple_sse.h | 225 ++++++++++++++++++++++++++++
> >  2 files changed, 226 insertions(+), 165 deletions(-)
> >  create mode 100644 drivers/net/virtio/virtio_rxtx_simple_sse.h
> >
> I think it's better to move sse implementation to a C file,
> as Bruce pointed out at
> http://www.dpdk.org/ml/archives/dev/2016-April/037937.html

I can move to C file, That would call for further restructuring of the code
by Introducing a new file drivers/net/virtio/virtio_rxtx_simple.h and
moving all static inline functions of virtio_rxtx_simple.c so that
virtio_rxtx_simple_sse.c and virtio_rxtx_simple_neon.c can include it.

Huawei,Yuanhan,All,

Are you OK with above restructuring?

Jerin

> 
> Jianbo