From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2] net/virtio-user: fix implicit int to enum conversion Date: Thu, 30 Jun 2016 13:28:33 +0800 Message-ID: <20160630052833.GB2831@yliu-dev.sh.intel.com> References: <1466667620-67731-1-git-send-email-jianfeng.tan@intel.com> <1466948893-11887-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, huawei.xie@intel.com, stephen@networkplumber.org To: Jianfeng Tan Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7B3CE2BFF for ; Thu, 30 Jun 2016 07:28:04 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1466948893-11887-1-git-send-email-jianfeng.tan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jun 26, 2016 at 01:48:13PM +0000, Jianfeng Tan wrote: > Implicit int to enum conversion is not allowed when icc is used as > the compiler. It raises the compiling error like, > /.../dpdk/drivers/net/virtio/virtio_user/vhost_user.c(257): > error #188: enumerated type mixed with another type > msg.request = req; > ^ > > The fix is simple, change the type of parameter req to enum > vhost_user_request. > > Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") > > Suggested-by: Stephen Hemminger > Signed-off-by: Jianfeng Tan Applied to dpdk-next-virtio, with the title changed to: net/virtio-user: fix build error with icc Thanks. --yliu