From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] mempool: rename functions with confusing names Date: Thu, 30 Jun 2016 13:08:53 +0100 Message-ID: <20160630120852.GA15232@bricha3-MOBL3> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467217635-19766-1-git-send-email-bruce.richardson@intel.com> <1585831.LcblvschXd@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com To: Thomas Monjalon Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0729A2B84 for ; Thu, 30 Jun 2016 14:08:56 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1585831.LcblvschXd@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 30, 2016 at 02:00:16PM +0200, Thomas Monjalon wrote: > 2016-06-29 17:27, Bruce Richardson: > > Fix this by introducing two new functions to replace the old ones, > > * rte_mempool_avail_count to replace rte_mempool_count > > * rte_mempool_in_use_count to replace rte_mempool_free_count > > This patch needs to be rebased please. > > > --- a/lib/librte_mempool/rte_mempool_version.map > > +++ b/lib/librte_mempool/rte_mempool_version.map > > @@ -32,5 +32,6 @@ DPDK_16.07 { > > rte_mempool_populate_virt; > > rte_mempool_register_ops; > > rte_mempool_set_ops_byname; > > + rte_mempool_avail_count; > > The "in_use_count" function is missing. > Please keep alphabetical order. We need a search-replace function that is smart enough to reorder things for us!