From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] mempool: rename functions with confusing names Date: Thu, 30 Jun 2016 13:09:50 +0100 Message-ID: <20160630120950.GB15232@bricha3-MOBL3> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467217635-19766-1-git-send-email-bruce.richardson@intel.com> <1585831.LcblvschXd@xps13> <98f41037-a666-53b6-efce-65a73a218d29@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com To: Panu Matilainen Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6A1A22949 for ; Thu, 30 Jun 2016 14:09:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: <98f41037-a666-53b6-efce-65a73a218d29@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 30, 2016 at 03:02:22PM +0300, Panu Matilainen wrote: > On 06/30/2016 03:00 PM, Thomas Monjalon wrote: > >2016-06-29 17:27, Bruce Richardson: > >>Fix this by introducing two new functions to replace the old ones, > >>* rte_mempool_avail_count to replace rte_mempool_count > >>* rte_mempool_in_use_count to replace rte_mempool_free_count > > > >This patch needs to be rebased please. > > > >>--- a/lib/librte_mempool/rte_mempool_version.map > >>+++ b/lib/librte_mempool/rte_mempool_version.map > >>@@ -32,5 +32,6 @@ DPDK_16.07 { > >> rte_mempool_populate_virt; > >> rte_mempool_register_ops; > >> rte_mempool_set_ops_byname; > >>+ rte_mempool_avail_count; > > > >The "in_use_count" function is missing. > > Its missing because the function is static inline. If you ask me, this would > be as fine time as any to remove that inlining ;) > > - Panu - > Yep, and yep. V3 needed, I'll see what I can do. /Bruce > >Please keep alphabetical order. > > > >