From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2 1/3] virtio: conditional compilation
	cleanup
Date: Mon, 4 Jul 2016 15:36:48 +0800
Message-ID: <20160704073648.GV2831@yliu-dev.sh.intel.com>
References: <1467028448-8914-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1467371814-26754-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1467371814-26754-2-git-send-email-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, bruce.richardson@intel.com,
 jianbo.liu@linaro.org, huawei.xie@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id CAA59379E
 for <dev@dpdk.org>; Mon,  4 Jul 2016 09:35:37 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1467371814-26754-2-git-send-email-jerin.jacob@caviumnetworks.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 01, 2016 at 04:46:36PM +0530, Jerin Jacob wrote:
> @@ -494,9 +486,6 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,
>  {
>  	uint8_t vtpci_queue_idx = 2 * queue_idx + VTNET_SQ_TQ_QUEUE_IDX;
>  
> -#ifdef RTE_MACHINE_CPUFLAG_SSSE3
> -	struct virtio_hw *hw = dev->data->dev_private;
> -#endif
>  	struct virtnet_tx *txvq;
>  	struct virtqueue *vq;
>  	uint16_t tx_free_thresh;
> @@ -511,13 +500,14 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev,
>  	}
>  
>  #ifdef RTE_MACHINE_CPUFLAG_SSSE3
> +	struct virtio_hw *hw = dev->data->dev_private;

I'd suggest to move above declaration to ...

>  	/* Use simple rx/tx func if single segment and no offloads */
>  	if ((tx_conf->txq_flags & VIRTIO_SIMPLE_FLAGS) == VIRTIO_SIMPLE_FLAGS &&
>  	     !vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {

here: we should try to avoid declaring vars in the middle of a code block.

	--yliu