From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2 1/3] virtio: conditional compilation
	cleanup
Date: Mon, 4 Jul 2016 20:57:15 +0800
Message-ID: <20160704125715.GF26521@yliu-dev.sh.intel.com>
References: <1467371814-26754-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1467371814-26754-2-git-send-email-jerin.jacob@caviumnetworks.com>
 <20160704073648.GV2831@yliu-dev.sh.intel.com>
 <20160704083626.GA12596@localhost.localdomain>
 <20160704084232.GY2831@yliu-dev.sh.intel.com>
 <20160704090754.GD12596@localhost.localdomain>
 <20160704110225.GA2831@yliu-dev.sh.intel.com>
 <20160704121556.GA5050@localhost.localdomain>
 <20160704122630.GB26521@yliu-dev.sh.intel.com>
 <20160704125041.GA6532@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas.monjalon@6wind.com, bruce.richardson@intel.com,
 jianbo.liu@linaro.org, huawei.xie@intel.com
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 083E62BAD
 for <dev@dpdk.org>; Mon,  4 Jul 2016 14:56:08 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160704125041.GA6532@localhost.localdomain>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 04, 2016 at 06:20:42PM +0530, Jerin Jacob wrote:
> > > The former case will have issue as "hw" been used in "if" with vtpci_with_feature.
> > 
> > Oh, my bad. I overlooked it. Sorry for that!
> > 
> > > OR
> > > 
> > > if you meant just floating "struct virtio_hw *hw" without RTE_MACHINE_CPUFLAG_SSSE3
> > > then it comes error on non x86 as unused "hw" variable.
> > > 
> > > If you meant something else then let me know?
> > 
> > I then prefer to keep the "#ifdef .. #endif" on top then. It will stop
> > us from offending a minor rule, while you can remove the ugly "#ifdef"
> > block in the next patch.
> > 
> > Works to you?
> 
> OK. As you wish :-)

Thank you!

	--yliu