From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH v3] mempool: replace c memcpy code semantics with optimized rte_memcpy Date: Tue, 5 Jul 2016 18:43:57 +0530 Message-ID: <20160705131356.GA12235@localhost.localdomain> References: <1464250025-9191-1-git-send-email-jerin.jacob@caviumnetworks.com> <1467288996-6109-1-git-send-email-jerin.jacob@caviumnetworks.com> <1752001.JOCExCpW7T@xps13> <577B7317.50608@intel.com> <20160705113246.GI26521@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: Ferruh Yigit , Thomas Monjalon , , , Pablo de Lara To: Yuanhan Liu Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0062.outbound.protection.outlook.com [104.47.33.62]) by dpdk.org (Postfix) with ESMTP id 9575D5949 for ; Tue, 5 Jul 2016 15:14:22 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160705113246.GI26521@yliu-dev.sh.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 05, 2016 at 07:32:46PM +0800, Yuanhan Liu wrote: > On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote: > > On 6/30/2016 6:28 PM, Thomas Monjalon wrote: > > > 2016-06-30 17:46, Jerin Jacob: > > >> Signed-off-by: Jerin Jacob > > >> Acked-by: Olivier Matz > > >=20 > > > Applied, thanks > > >=20 > >=20 > > Hi Jerin, > >=20 > > This commit cause a compilation error on target i686-native-linuxapp-= gcc > > with gcc6. >=20 > Besides that, I'm more curious to know have you actually seen any > performance boost? let me first address your curiosity, http://dpdk.org/dev/patchwork/patch/12993/( check the second comment) http://dpdk.org/ml/archives/dev/2016-June/042701.html Ferruh, I have tested on a x86 machine with gcc 6.1. I could n't see any issues with i686-native-linuxapp-gcc target Steps following to create gcc 6.1 toolchain https://sahas.ra.naman.ms/2016/05/31/building-gcc6-1-on-fedora-23/ (removed --disable-multilib to have support for -m32) =E2=9E=9C [dpdk-master] $ gcc -v Using built-in specs. COLLECT_GCC=3Dgcc COLLECT_LTO_WRAPPER=3D/opt/gcc-6.1.0/libexec/gcc/x86_64-pc-linux-gnu/6.1.= 0/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: ../gcc-6.1.0/configure --prefix=3D/opt/gcc-6.1.0 --enable-languages=3Dc,c++ --enable-libmudflap --with-system-zlib Thread model: posix gcc version 6.1.0 (GCC) More over this issue seems like an issue from x86 rte_memcpy implementati= on. Jerin