From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v3] mempool: replace c memcpy code semantics with optimized rte_memcpy Date: Tue, 5 Jul 2016 21:42:07 +0800 Message-ID: <20160705134207.GM26521@yliu-dev.sh.intel.com> References: <1464250025-9191-1-git-send-email-jerin.jacob@caviumnetworks.com> <1467288996-6109-1-git-send-email-jerin.jacob@caviumnetworks.com> <1752001.JOCExCpW7T@xps13> <577B7317.50608@intel.com> <20160705113246.GI26521@yliu-dev.sh.intel.com> <20160705131356.GA12235@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org, olivier.matz@6wind.com, Pablo de Lara To: Jerin Jacob Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 07FE75955 for ; Tue, 5 Jul 2016 15:40:43 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160705131356.GA12235@localhost.localdomain> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 05, 2016 at 06:43:57PM +0530, Jerin Jacob wrote: > On Tue, Jul 05, 2016 at 07:32:46PM +0800, Yuanhan Liu wrote: > > On Tue, Jul 05, 2016 at 09:43:03AM +0100, Ferruh Yigit wrote: > > > On 6/30/2016 6:28 PM, Thomas Monjalon wrote: > > > > 2016-06-30 17:46, Jerin Jacob: > > > >> Signed-off-by: Jerin Jacob > > > >> Acked-by: Olivier Matz > > > > > > > > Applied, thanks > > > > > > > > > > Hi Jerin, > > > > > > This commit cause a compilation error on target i686-native-linuxapp-gcc > > > with gcc6. > > > > Besides that, I'm more curious to know have you actually seen any > > performance boost? > > let me first address your curiosity, > http://dpdk.org/dev/patchwork/patch/12993/( check the second comment) > http://dpdk.org/ml/archives/dev/2016-June/042701.html Thanks. Maybe it's good to include those info in the commit log next time. --yliu