From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH 07/11] pmdinfogen: fix build warnings Date: Thu, 7 Jul 2016 13:55:27 -0400 Message-ID: <20160707175527.GN26064@hmsreliant.think-freely.org> References: <1467905790-10597-1-git-send-email-thomas.monjalon@6wind.com> <1467905790-10597-8-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id C05402BF7 for ; Thu, 7 Jul 2016 19:55:51 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1467905790-10597-8-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 07, 2016 at 05:36:26PM +0200, Thomas Monjalon wrote: > When compiled with a standard clang, pmdinfogen can raise a warning: > buildtools/pmdinfogen/pmdinfogen.c:365:1: warning: > control reaches end of non-void function >=20 > Actually there can be more warnings with stricter compilers. > In order to catch them early and fix most of them, the DPDK standard fl= ags > WERROR_FLAGS are used. >=20 > The warnings fixed are: > no previous prototype for ... > no return statement in function returning non-void > variable =E2=80=98secstrings=E2=80=99 set but not used > =E2=80=98sec_name=E2=80=99 defined but not used > =E2=80=98get_symbol_index=E2=80=99 defined but not used > pointer of type =E2=80=98void *=E2=80=99 used in arithmetic >=20 > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility= ") >=20 > Signed-off-by: Thomas Monjalon > --- I'm not opposed to any of these changes, but I'm really starting to wonde= r how well used/maintained clang is as a toolchain target. I assert that becau= se, with my admittedly broken dependency rule, a native clang build for me er= rors out in any number of places: /home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: erro= r: equality comparison with extraneous parentheses [-Werror,-Wparentheses-eq= uality] if (((&pci_device_list)->tqh_first =3D=3D ((void*)0))) { ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ /home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: note= : remove extraneous parentheses around the comparison to silence this warni= ng if (((&pci_device_list)->tqh_first =3D=3D ((void*)0))) { ~ ^ ~ /home/nhorman/git/dpdk/lib/librte_eal/linuxapp/eal/eal_pci.c:392:37: note= : use '=3D' to turn this equality comparison into an assignment if (((&pci_device_list)->tqh_first =3D=3D ((void*)0))) { along with several others ... The above are (in part) asserted based on the definition of the TAILQ_EMP= TY macro which is from glibc, and has been unchanged for a number of years. This error occ= urs on clang 3.7.0 for me. Not saying we can't fix these warnings your getting,= but if clang has been tripping over the above for I don't know how long, I have = to question how important clang is. Neil > buildtools/pmdinfogen/Makefile | 4 +-- > buildtools/pmdinfogen/pmdinfogen.c | 58 ++++++++++++------------------= -------- > 2 files changed, 20 insertions(+), 42 deletions(-) >=20 > diff --git a/buildtools/pmdinfogen/Makefile b/buildtools/pmdinfogen/Mak= efile > index 125901b..3885d3b 100644 > --- a/buildtools/pmdinfogen/Makefile > +++ b/buildtools/pmdinfogen/Makefile > @@ -41,9 +41,9 @@ HOSTAPP =3D pmdinfogen > # > SRCS-y +=3D pmdinfogen.c > =20 > -HOST_EXTRA_CFLAGS +=3D -g -I${RTE_OUTPUT}/include > +HOST_CFLAGS +=3D $(WERROR_FLAGS) -g > +HOST_CFLAGS +=3D -I$(RTE_OUTPUT)/include > =20 > DEPDIRS-y +=3D lib/librte_eal > =20 > include $(RTE_SDK)/mk/rte.hostapp.mk > - > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen= /pmdinfogen.c > index 0947dc6..beb06f1 100644 > --- a/buildtools/pmdinfogen/pmdinfogen.c > +++ b/buildtools/pmdinfogen/pmdinfogen.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include "pmdinfogen.h" > =20 > #ifdef RTE_ARCH_64 > @@ -32,7 +33,7 @@ static const char *sym_name(struct elf_info *elf, Elf= _Sym *sym) > return "(unknown)"; > } > =20 > -void *grab_file(const char *filename, unsigned long *size) > +static void *grab_file(const char *filename, unsigned long *size) > { > struct stat st; > void *map =3D MAP_FAILED; > @@ -59,7 +60,7 @@ failed: > * spaces in the beginning of the line is trimmed away. > * Return a pointer to a static buffer. > **/ > -void release_file(void *file, unsigned long size) > +static void release_file(void *file, unsigned long size) > { > munmap(file, size); > } > @@ -67,9 +68,8 @@ void release_file(void *file, unsigned long size) > =20 > static void *get_sym_value(struct elf_info *info, const Elf_Sym *sym) > { > - void *ptr =3D (void *)info->hdr + info->sechdrs[sym->st_shndx].sh_off= set; > - > - return (void *)(ptr + sym->st_value); > + return RTE_PTR_ADD(info->hdr, > + info->sechdrs[sym->st_shndx].sh_offset + sym->st_value); > } > =20 > static Elf_Sym *find_sym_in_symtab(struct elf_info *info, > @@ -95,7 +95,6 @@ static int parse_elf(struct elf_info *info, const cha= r *filename) > Elf_Ehdr *hdr; > Elf_Shdr *sechdrs; > Elf_Sym *sym; > - const char *secstrings; > int endian; > unsigned int symtab_idx =3D ~0U, symtab_shndx_idx =3D ~0U; > =20 > @@ -140,7 +139,7 @@ static int parse_elf(struct elf_info *info, const c= har *filename) > hdr->e_shnum =3D TO_NATIVE(endian, 16, hdr->e_shnum); > hdr->e_shstrndx =3D TO_NATIVE(endian, 16, hdr->e_shstrndx); > =20 > - sechdrs =3D (void *)hdr + hdr->e_shoff; > + sechdrs =3D RTE_PTR_ADD(hdr, hdr->e_shoff); > info->sechdrs =3D sechdrs; > =20 > /* Check if file offset is correct */ > @@ -191,7 +190,6 @@ static int parse_elf(struct elf_info *info, const c= har *filename) > TO_NATIVE(endian, ADDR_SIZE, sechdrs[i].sh_entsize); > } > /* Find symbol table. */ > - secstrings =3D (void *)hdr + sechdrs[info->secindex_strings].sh_offse= t; > for (i =3D 1; i < info->num_sections; i++) { > int nobits =3D sechdrs[i].sh_type =3D=3D SHT_NOBITS; > =20 > @@ -206,22 +204,22 @@ static int parse_elf(struct elf_info *info, const= char *filename) > if (sechdrs[i].sh_type =3D=3D SHT_SYMTAB) { > unsigned int sh_link_idx; > symtab_idx =3D i; > - info->symtab_start =3D (void *)hdr + > - sechdrs[i].sh_offset; > - info->symtab_stop =3D (void *)hdr + > - sechdrs[i].sh_offset + sechdrs[i].sh_size; > + info->symtab_start =3D RTE_PTR_ADD(hdr, > + sechdrs[i].sh_offset); > + info->symtab_stop =3D RTE_PTR_ADD(hdr, > + sechdrs[i].sh_offset + sechdrs[i].sh_size); > sh_link_idx =3D sechdrs[i].sh_link; > - info->strtab =3D (void *)hdr + > - sechdrs[sh_link_idx].sh_offset; > + info->strtab =3D RTE_PTR_ADD(hdr, > + sechdrs[sh_link_idx].sh_offset); > } > =20 > /* 32bit section no. table? ("more than 64k sections") */ > if (sechdrs[i].sh_type =3D=3D SHT_SYMTAB_SHNDX) { > symtab_shndx_idx =3D i; > - info->symtab_shndx_start =3D (void *)hdr + > - sechdrs[i].sh_offset; > - info->symtab_shndx_stop =3D (void *)hdr + > - sechdrs[i].sh_offset + sechdrs[i].sh_size; > + info->symtab_shndx_start =3D RTE_PTR_ADD(hdr, > + sechdrs[i].sh_offset); > + info->symtab_shndx_stop =3D RTE_PTR_ADD(hdr, > + sechdrs[i].sh_offset + sechdrs[i].sh_size); > } > } > if (!info->symtab_start) > @@ -262,28 +260,6 @@ static void parse_elf_finish(struct elf_info *info= ) > } > } > =20 > -static const char *sec_name(struct elf_info *elf, int secindex) > -{ > - Elf_Shdr *sechdrs =3D elf->sechdrs; > - return (void *)elf->hdr + > - elf->sechdrs[elf->secindex_strings].sh_offset + > - sechdrs[secindex].sh_name; > -} > - > -static int get_symbol_index(struct elf_info *info, Elf_Sym *sym) > -{ > - const char *name =3D sym_name(info, sym); > - const char *idx; > - > - idx =3D name; > - while (idx) { > - if (isdigit(*idx)) > - return atoi(idx); > - idx++; > - } > - return -1; > -} > - > struct opt_tag { > const char *suffix; > const char *json_id; > @@ -362,6 +338,8 @@ static int locate_pmd_entries(struct elf_info *info= ) > } > } > } while (last); > + > + return 0; > } > =20 > static void output_pmd_info_string(struct elf_info *info, char *outfil= e) > --=20 > 2.7.0 >=20 >=20