From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] net/mlx5: fix a segmentation fault in Rx
Date: Fri, 8 Jul 2016 21:53:24 +0100
Message-ID: <20160708205324.GC34980@bricha3-MOBL3>
References: <a28e9283e37e0911f9454edfc8f49b4d312e912d.1467981553.git.nelio.laranjeiro@6wind.com>
 <20160708132902.GF7621@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org,
 Olga Shern <olgas@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 90DEB8E65
 for <dev@dpdk.org>; Fri,  8 Jul 2016 22:53:28 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160708132902.GF7621@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jul 08, 2016 at 03:29:02PM +0200, Adrien Mazarguil wrote:
> On Fri, Jul 08, 2016 at 02:43:26PM +0200, Nelio Laranjeiro wrote:
> > Fixed issue could occur when a Mbuf starvation happens in a middle of
> > reception of a segmented packet, in such situation, the PMD has to release
> > all segments of such packet.  The end condition was wrong causing it to
> > free a Mbuf still handled by the NIC.
> > 
> > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support")
> > 
> > Reported-by: Yongseok Koh <yskoh@mellanox.com>
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
> >  drivers/net/mlx5/mlx5_rxtx.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> > index 0c352f3..3564937 100644
> > --- a/drivers/net/mlx5/mlx5_rxtx.c
> > +++ b/drivers/net/mlx5/mlx5_rxtx.c
> > @@ -1572,7 +1572,8 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n)
> >  		rte_prefetch0(wqe);
> >  		rep = rte_mbuf_raw_alloc(rxq->mp);
> >  		if (unlikely(rep == NULL)) {
> > -			while (pkt) {
> > +			while (pkt != seg) {
> > +				assert(pkt != (*rxq->elts)[idx]);
> >  				seg = NEXT(pkt);
> >  				rte_mbuf_refcnt_set(pkt, 0);
> >  				__rte_mbuf_raw_free(pkt);
> > -- 
> > 2.1.4
> > 
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
Applied to dpdk-next-net/rel_16_07

/Bruce