From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 1/2] net/enic: fix setting MAC address when a port is restarted Date: Fri, 8 Jul 2016 22:00:49 +0100 Message-ID: <20160708210049.GF34980@bricha3-MOBL3> References: <1467940221-11341-1-git-send-email-neescoba@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Nelson Escobar Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7088F8E6E for ; Fri, 8 Jul 2016 23:00:53 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1467940221-11341-1-git-send-email-neescoba@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 07, 2016 at 06:10:21PM -0700, Nelson Escobar wrote: > enic_disable() removed the MAC address when a port was shut down but > enic_enable() didn't add the MAC address back when the port was > started again. Move where we set the MAC address for the adapter from > enic_setup_finish() to a enic_enable() so that port restarting works > properly. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: Nelson Escobar > Reviewed-by: John Daley > --- Patchset applied to dpdk-next-net/rel_16_07 /Bruce