From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] ena: fix doorbell submission when not needed Date: Fri, 8 Jul 2016 22:03:34 +0100 Message-ID: <20160708210334.GG34980@bricha3-MOBL3> References: <20160708111130.28056-1-jan@semihalf.com> <20160708111130.28056-2-jan@semihalf.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas.monjalon@6wind.com, Alexander Matushevsky To: Jan Medala Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5879F95C8 for ; Fri, 8 Jul 2016 23:03:56 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160708111130.28056-2-jan@semihalf.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jul 08, 2016 at 01:11:30PM +0200, Jan Medala wrote: > Avoid submitting doorbell when: > * no packets have been submitted to TX > * no free resources have been submitted while RX > > Sending doorbell without actual work to be performed by device > violates ENA specification and can lead to unpredictable behavior. > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > > Signed-off-by: Alexander Matushevsky > Signed-off-by: Jan Medala > --- Applied to dpdk-net-net/rel_16_07 /Bruce