From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3 01/13] e1000: move pci device ids to driver
Date: Mon, 11 Jul 2016 14:05:15 +0800
Message-ID: <20160711060515.GX26521@yliu-dev.sh.intel.com>
References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com>
 <2858831.tSF8KXeB50@xps13>
 <20160711053326.GW26521@yliu-dev.sh.intel.com>
 <1698058.nWbIbKdPp2@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
 stephen@networkplumber.org, bruce.richardson@intel.com,
 nhorman@tuxdriver.com, pmatilai@redhat.com,
 christian.ehrhardt@canonical.com, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 ferruh.yigit@intel.com, Rasesh Mody <rasesh.mody@qlogic.com>,
 johndale@cisco.com, Yong Wang <yongwang@vmware.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 0E2BA2B93
 for <dev@dpdk.org>; Mon, 11 Jul 2016 08:02:54 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1698058.nWbIbKdPp2@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 11, 2016 at 07:56:16AM +0200, Thomas Monjalon wrote:
> 2016-07-11 13:33, Yuanhan Liu:
> > On Fri, Jul 08, 2016 at 03:31:27PM +0200, Thomas Monjalon wrote:
> > > 2016-04-20 14:43, David Marchand:
> > > > test application and kni still want to know e1000 pci devices.
> > > > So let's create headers in the driver that will be used by them.
> > > 
> > > There is also an usage of ixgbe ID for the broken bypass API.
> > > 
> > > Sharing those PCI ids outside of the drivers was really a wrong idea.
> > > So this a plan to get rid of them:
> > > 
> > > 1/ remove need in PCI autotest (done: http://dpdk.org/commit/1dbba165)
> > > 2/ move PCI ids in bnx2x, bnxt, e1000, enic, fm10k, i40e, virtio, vmxnet3
> > > 3/ remove KNI ethtool (only igb/ixgbe support)
> > > 4/ remove bypass API or move it to ixgbe specific API
> > > 5/ move remaining PCI ids in igb and ixgbe drivers
> > > 
> > > Please driver maintainers, move your PCI ids in your drivers as soon as
> > > possible. Thanks
> > 
> > Hi Thomas,
> > 
> > I'm not quite sure I understood it well: are you asking us to resend
> > what David has already send, say me for resending the virtio part?
> > 
> > If so, what's the point of that? What's worse, it's likely to fail
> > apply (due to conflicts), as every one of us make a patch based on
> > the same base while touching some same files.
> 
> Good point.
> There were some changes since the patches from David (and a new bnxt).
> That's why I was thinking to ask maintainers to take care of this change.
> But maybe it's better to do the change in one patchset.

Yes, I'd think so.

	--yliu

> David, ok to refresh these patches?