From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v3 01/13] e1000: move pci device ids to driver Date: Mon, 11 Jul 2016 20:05:28 +0800 Message-ID: <20160711120528.GA26521@yliu-dev.sh.intel.com> References: <1453120248-28274-1-git-send-email-david.marchand@6wind.com> <2858831.tSF8KXeB50@xps13> <20160711053326.GW26521@yliu-dev.sh.intel.com> <1698058.nWbIbKdPp2@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , "dev@dpdk.org" , Stephen Hemminger , "Richardson, Bruce" , Neil Horman , Panu Matilainen , Christian Ehrhardt , Wenzhuo Lu , Ferruh Yigit , Rasesh Mody , johndale@cisco.com, Yong Wang To: David Marchand Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5E2CD914 for ; Mon, 11 Jul 2016 14:03:09 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 11, 2016 at 01:35:46PM +0200, David Marchand wrote: > Hello all, > > On Mon, Jul 11, 2016 at 7:56 AM, Thomas Monjalon > wrote: > > 2016-07-11 13:33, Yuanhan Liu: > >> I'm not quite sure I understood it well: are you asking us to resend > >> what David has already send, say me for resending the virtio part? > >> > >> If so, what's the point of that? What's worse, it's likely to fail > >> apply (due to conflicts), as every one of us make a patch based on > >> the same base while touching some same files. > > > > Good point. > > There were some changes since the patches from David (and a new bnxt). > > That's why I was thinking to ask maintainers to take care of this change. > > But maybe it's better to do the change in one patchset. > > David, ok to refresh these patches? > > Now that we have a modinfo-like infra and the test code is exempt from > igb pci ids, all that remains (to fully get rid of this header) are > bypass api and kni/ethtool. > So the deal with Thomas is that I refresh those patches letting igb > and ixgbe pmd as is. > > Will send this later. Thanks, and feel free to put my ack for the virtio part. Acked-by: Yuanhan Liu Great work, BTW! --yliu