From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] net/virtio-user: Fix missing brackets in if
	condition
Date: Tue, 12 Jul 2016 20:11:14 +0800
Message-ID: <20160712121114.GF26521@yliu-dev.sh.intel.com>
References: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: huawei.xie@intel.com, dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 62B301C52
 for <dev@dpdk.org>; Tue, 12 Jul 2016 14:08:39 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jul 12, 2016 at 11:30:25AM +0200, Maxime Coquelin wrote:
> The error is reported using test build script:
>=20
> $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> ...
> drivers/net/virtio/virtio_user_ethdev.c: In function =E2=80=98virtio_us=
er_pmd_devinit=E2=80=99:
> drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this =E2=80=98if=E2=
=80=99 clause does not guard... [-Werror=3Dmisleading-indentation]
>   if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1)
>     ^~
>=20
> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
>=20
> Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Thanks for the fix.

	--yliu