From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [PATCH] virtio: fix missing curly braces
Date: Wed, 13 Jul 2016 19:43:51 +0200
Message-ID: <20160713194351.0ca1f914@jvn>
References: <20160713092419.14425-1-viktorin@rehivetech.com>
 <7046512f-49fa-30b4-9238-318617cc04be@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Jianfeng Tan <jianfeng.tan@intel.com>, Yuanhan Liu
 <yuanhan.liu@linux.intel.com>, Huawei Xie <huawei.xie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15])
 by dpdk.org (Postfix) with ESMTP id BC98F2C31
 for <dev@dpdk.org>; Wed, 13 Jul 2016 19:43:46 +0200 (CEST)
In-Reply-To: <7046512f-49fa-30b4-9238-318617cc04be@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 13 Jul 2016 11:27:18 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:

> Hi Jan,
>=20
> On 07/13/2016 11:24 AM, Jan Viktorin wrote:
> > GCC 6 is complaining and seems to be correct here.
> >
> > virtio_user_ethdev.c:345:2: error:
> > 	this =E2=80=98if=E2=80=99 clause does not guard... [-Werror=3Dmisleadi=
ng-indentation]
> >    if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1)
> >    ^~
> >
> > virtio_user_ethdev.c:348:3: note:
> > 	...this statement, but the latter is misleadingly indented
> > 	as if it is guarded by the =E2=80=98if=E2=80=99
> >     if (ret < 0) {
> >
> > Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
> > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> > ---
> > =20
> I already fixed it yesterday:
> http://dpdk.org/dev/patchwork/patch/14780/

Sorry, I didn't find it quickly. My fault. Thanks.

Jan

>=20
> Thanks,
> Maxime