From mboxrd@z Thu Jan  1 00:00:00 1970
From: viktorin@rehivetech.com
Subject: Re: net/virtio-user: Fix missing brackets in if condition
Date: Thu, 14 Jul 2016 18:31:11 +0200
Message-ID: <20160714183111.4d44e564@jvn>
References: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: huawei.xie@intel.com, yuanhan.liu@linux.intel.com, dev@dpdk.org,
 Jianfeng Tan <jianfeng.tan@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16])
 by dpdk.org (Postfix) with ESMTP id EB28D37A4
 for <dev@dpdk.org>; Thu, 14 Jul 2016 18:31:07 +0200 (CEST)
In-Reply-To: <1468315825-24089-1-git-send-email-maxime.coquelin@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 12 Jul 2016 11:30:25 +0200
Maxime Coquelin <maxime.coquelin@redhat.com> wrote:

> The error is reported using test build script:

I recommend to note that the error is reported only by GCC 6+.

>=20
> $ scripts/test-build.sh x86_64-native-linuxapp-gcc
> ...
> drivers/net/virtio/virtio_user_ethdev.c: In function =E2=80=98virtio_user=
_pmd_devinit=E2=80=99:
> drivers/net/virtio/virtio_user_ethdev.c:345:2: error: this =E2=80=98if=E2=
=80=99 clause does not guard... [-Werror=3Dmisleading-indentation]
>   if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) =3D=3D 1)
>     ^~
>=20
> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked")
>=20
> Cc: Jianfeng Tan <jianfeng.tan@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>=20
Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>