From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] vhost: fix off-by-one error on nr_desc check
Date: Mon, 25 Jul 2016 23:24:12 +0800
Message-ID: <20160725152412.GS28708@yliu-dev.sh.intel.com>
References: <1469455798-19790-1-git-send-email-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: huawei.xie@intel.com, dev@dpdk.org,
 Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 15D53377E
 for <dev@dpdk.org>; Mon, 25 Jul 2016 17:19:22 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1469455798-19790-1-git-send-email-maxime.coquelin@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 25, 2016 at 04:09:58PM +0200, Maxime Coquelin wrote:
> nr_desc is not an index but the number of descriptors,
> so can be equal to the virtqueue size.
> 
> Fixes: a436f53ebfeb ("vhost: avoid dead loop chain")
> 
> Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks for catching it!

> ---
> Hi Yuanhan,
> 
> I faced the bug while testing my indirect descriptor patch, it happens
> as soon as the number of chained descritors is above 2.
> 
> But the bug may in theory also be faced with normal descriptors,

In theory, yes, and only in one case, that there is a Tx has 256
descriptors chained. If that happens, I doubt things work well.
So I would say it just happens __in theory__.

> so it might
> be good to have it 16.07?

Even though, it apparently fixes a bug, so I think we could have it
for 16.07.

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu