From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] lpm: remove redundant check when adding lpm rule Date: Tue, 2 Aug 2016 17:04:10 +0100 Message-ID: <20160802160410.GC17728@bricha3-MOBL3> References: <1470059264-29772-1-git-send-email-wei.dai@intel.com> <1470103765-18226-1-git-send-email-wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Wei Dai Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 943252BDB for ; Tue, 2 Aug 2016 18:06:46 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1470103765-18226-1-git-send-email-wei.dai@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 02, 2016 at 10:09:25AM +0800, Wei Dai wrote: > When a rule with depth > 24 is added into an existing > rule with depth <=24, a new tbl8 is allocated, the existing > rule first fulfill whole new tbl8, so the filed vaild of typo "valid" > each entry in this tbl8 is always true and depth of each > entry is always < 24 before adding new rule with depth > 24. > > Signed-off-by: Wei Dai Acked-by: Bruce Richardson Having to make this change twice shows up the fact that we are still carrying around some version changes for older releases. Given that we are now past the 16.07 release, the old code can probably be removed. Any volunteers to maybe do up a patch for that. Regards, /Bruce