From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH 1/2] examples/vhost: rename dev-basename Date: Tue, 23 Aug 2016 14:01:52 +0800 Message-ID: <20160823060152.GE30752@yliu-dev.sh.intel.com> References: <1471364079-116217-2-git-send-email-jiayu.hu@intel.com> <1471687833-17834-1-git-send-email-jiayu.hu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, maxime.coquelin@redhat.com To: Jiayu Hu Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 172C0378B for ; Tue, 23 Aug 2016 07:52:10 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1471687833-17834-1-git-send-email-jiayu.hu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Aug 20, 2016 at 06:10:33AM -0400, Jiayu Hu wrote: > In examples/vhost, "dev-basename" is a program option, which is to set > the vhost-net socket used by vhost-user, or the character device used > by vhost-cuse. Since vhost-cuse should be dropped, and "dev-basename" > is not a suitable name for the vhost-net socket. Therefore, this patch > is to change this option name for examples/vhost. > > Signed-off-by: Jiayu Hu > Reviewed-by: Maxime Coquelin Applied to dpdk-next-virtio. However, I got few more minor notes for you: - about --in-reply-to You should send all patches once, and link it to the former version's cover letter. - You should add v2 prefix. This could be done by: $ git format-patch -v 2 ... --yliu