From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 00/22] pcap pmd improvements
Date: Fri, 26 Aug 2016 10:38:55 -0700
Message-ID: <20160826103855.1b15f716@xeon-e3>
References: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f179.google.com (mail-pf0-f179.google.com
 [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id EA2712C55
 for <dev@dpdk.org>; Fri, 26 Aug 2016 19:38:42 +0200 (CEST)
Received: by mail-pf0-f179.google.com with SMTP id y134so30605458pfg.0
 for <dev@dpdk.org>; Fri, 26 Aug 2016 10:38:42 -0700 (PDT)
In-Reply-To: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 26 Aug 2016 12:17:37 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> No new feature added, code refactored.
> 
> Ferruh Yigit (22):
>   net/pcap: convert config option to a macro
>   net/pcap: use macros for param string
>   net/pcap: reorganize private structs
>   net/pcap: add checks for max queue number
>   net/pcap: update function to reuse it
>   net/pcap: don't carry numa_node argument
>   net/pcap: don't carry kvlist argument
>   net/pcap: move comment to correct place
>   net/pcap: remove duplicated max queue number check
>   net/pcap: use single_iface variable instead of hardcoded
>   net/pcap: group stats related fields into a struct
>   net/pcap: make const array static
>   net/pcap: reorder header files
>   net/pcap: reorder functions
>   net/pcap: update how single iface handled
>   net/pcap: remove unnecessary check
>   net/pcap: remove redundant assignment
>   net/pcap: simplify function
>   net/pcap: fix missing Tx iface assignment
>   net/pcap: coding convention updates
>   net/pcap: remove rte prefix from static functions
>   net/pcap: fix checkpatch warnings
> 
>  drivers/net/pcap/rte_eth_pcap.c | 644 +++++++++++++++++++---------------------
>  1 file changed, 309 insertions(+), 335 deletions(-)
> 

These all look like good ideas. Haven't tested this but they all are
simple changes.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>