From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3] eal: restrict cores detection Date: Fri, 2 Sep 2016 17:53:10 +0100 Message-ID: <20160902165310.GA20356@bricha3-MOBL3> References: <1453661393-85704-1-git-send-email-jianfeng.tan@intel.com> <1472693507-11369-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, david.marchand@6wind.com, pmatilai@redhat.com, thomas.monjalon@6wind.com, stephen@networkplumber.org To: Jianfeng Tan Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 07A0D2931 for ; Fri, 2 Sep 2016 18:53:14 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1472693507-11369-1-git-send-email-jianfeng.tan@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 01, 2016 at 01:31:47AM +0000, Jianfeng Tan wrote: > This patch uses pthread_getaffinity_np() to narrow down detected > cores before parsing coremask (-c), corelist (-l), and coremap > (--lcores). > > The purpose of this patch is to leave out these core related options > when DPDK applications are deployed under container env, so that > users only specify core restriction as starting the instance. > > Note: previously, some users are using isolated CPUs, which could > be excluded by default. Please add commands like taskset to use > those cores. > > Test example: > $ taskset 0xc0000 ./examples/helloworld/build/helloworld -m 1024 > So, to be clear, does this patch mean that DPDK cannot use isolated cores any more unless you explicitly run the app using taskset? Is so, NAK, since isolating cores has been part of standard DPDK setup since the first versions, and I don't believe that we should break that behaviour. /Bruce