From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] virtio: xstats name issue Date: Mon, 5 Sep 2016 12:33:29 +0800 Message-ID: <20160905043329.GJ30752@yliu-dev.sh.intel.com> References: <1472716874-34036-1-git-send-email-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Zhiyong Yang Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id F2A1A2B9C for ; Mon, 5 Sep 2016 06:21:34 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1472716874-34036-1-git-send-email-zhiyong.yang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Few generic (trivial) comments first: - cc to related maintainers - follow the right prefix, "net/virtio" but not "virtio" - start commit summary with a verb, and start with "fix" for bug fixing patch. On Thu, Sep 01, 2016 at 04:01:14PM +0800, Zhiyong Yang wrote: > The patch fixes some xstats name issues and make the xstats name conform to > code implementation(the function virtio_update_packet_stats). I would fix it inside virtio_update_packet_stats(), to keep the consistency of name style: starts with an even number, and ends with an odd number. --yliu > > Signed-off-by: Zhiyong Yang > --- > drivers/net/virtio/virtio_ethdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 07d6449..4cee067 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -125,8 +125,8 @@ static const struct rte_virtio_xstats_name_off rte_virtio_rxq_stat_strings[] = { > {"size_128_255_packets", offsetof(struct virtnet_rx, stats.size_bins[3])}, > {"size_256_511_packets", offsetof(struct virtnet_rx, stats.size_bins[4])}, > {"size_512_1023_packets", offsetof(struct virtnet_rx, stats.size_bins[5])}, > - {"size_1024_1517_packets", offsetof(struct virtnet_rx, stats.size_bins[6])}, > - {"size_1518_max_packets", offsetof(struct virtnet_rx, stats.size_bins[7])}, > + {"size_1024_1518_packets", offsetof(struct virtnet_rx, stats.size_bins[6])}, > + {"size_1519_max_packets", offsetof(struct virtnet_rx, stats.size_bins[7])}, > }; > > /* [rt]x_qX_ is prepended to the name string here */ > @@ -142,8 +142,8 @@ static const struct rte_virtio_xstats_name_off rte_virtio_txq_stat_strings[] = { > {"size_128_255_packets", offsetof(struct virtnet_tx, stats.size_bins[3])}, > {"size_256_511_packets", offsetof(struct virtnet_tx, stats.size_bins[4])}, > {"size_512_1023_packets", offsetof(struct virtnet_tx, stats.size_bins[5])}, > - {"size_1024_1517_packets", offsetof(struct virtnet_tx, stats.size_bins[6])}, > - {"size_1518_max_packets", offsetof(struct virtnet_tx, stats.size_bins[7])}, > + {"size_1024_1518_packets", offsetof(struct virtnet_tx, stats.size_bins[6])}, > + {"size_1519_max_packets", offsetof(struct virtnet_tx, stats.size_bins[7])}, > }; > > #define VIRTIO_NB_RXQ_XSTATS (sizeof(rte_virtio_rxq_stat_strings) / \ > -- > 2.5.5