From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v3]virtio:add mtu set in virtio Date: Wed, 7 Sep 2016 11:53:59 +0800 Message-ID: <20160907035359.GJ23158@yliu-dev.sh.intel.com> References: <20160907032156.34492-1-sodey@sonusnet.com> <20160907034252.GI23158@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "dev@dpdk.org" , "stephen@networkplumber.org" To: "Dey, Souvik" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id BCDD36CD4 for ; Wed, 7 Sep 2016 05:53:31 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 07, 2016 at 03:47:27AM +0000, Dey, Souvik wrote: > Ok will change it. Do I need to submit a new v4 for that ? Yes. > can I put your name also in the reviewed by list? Nope, you should not add that. I just offered some comments. And yes, I reviewed your patch, but that doesn't mean you could add my Reviewed-by. You can only add the Reviewed-by tag only when the reviewer gave it to you, explicitly, like following: Reviewed-by: Some One --yliu > > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Tuesday, September 6, 2016 11:43 PM > To: Dey, Souvik > Cc: dev@dpdk.org; stephen@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio > > On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > > +static int > > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > > + struct virtio_hw *hw = dev->data->dev_private; > > + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { > > + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); > > I forgot to mention in last email, that you should not use the number (64 and 9728) directly, use the MACRO instead. > > --yliu