From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v3 4/4] bonding: remove memcpy from burst functions Date: Sun, 11 Sep 2016 20:39:31 +0800 Message-ID: <20160911123931.GD23158@yliu-dev.sh.intel.com> References: <1464280727-25752-2-git-send-email-bernard.iremonger@intel.com> <1465751489-10111-1-git-send-email-bernard.iremonger@intel.com> <1465751489-10111-5-git-send-email-bernard.iremonger@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, declan.doherty@intel.com, konstantin.ananyev@intel.com, Thomas Monjalon To: Bernard Iremonger Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 8432C9E3 for ; Sun, 11 Sep 2016 14:39:00 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1465751489-10111-5-git-send-email-bernard.iremonger@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jun 12, 2016 at 06:11:29PM +0100, Bernard Iremonger wrote: > Now that the queue spinlocks have been added to the rx and > tx burst functions the memcpy of the slave data is no > longer necessary, so it has been removed. > > Signed-off-by: Bernard Iremonger > Acked-by: Konstantin Ananyev Hi, FYI, my testrobot caught some errors when this patch is applied. --yliu --- x86_64-native-linuxapp-clang: config-all-yes ============================================ grep: /lib/modules/4.6.0/build/include/generated/utsrelease.h: No such file or directory grep: /lib/modules/4.6.0/build/include/generated/utsrelease.h: No such file or directory /root/dpdk/drivers/net/bonding/rte_eth_bond_pmd.c:753:41: error: use of undeclared identifier 'slaves' mode6_debug("TX IPv4:", ether_hdr, slaves[i], &burstnumberTX); ^ 1 error generated. make[6]: *** [rte_eth_bond_pmd.o] Error 1 make[5]: *** [bonding] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [net] Error 2 make[3]: *** [drivers] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 error: build failed