From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH 00/22] pcap pmd improvements Date: Mon, 19 Sep 2016 17:42:56 +0100 Message-ID: <20160919164256.GN45548@bricha3-MOBL3> References: <1472210279-8286-1-git-send-email-ferruh.yigit@intel.com> <20160826103855.1b15f716@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ferruh Yigit , dev@dpdk.org To: Stephen Hemminger Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 88764374E for ; Mon, 19 Sep 2016 18:43:01 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160826103855.1b15f716@xeon-e3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Aug 26, 2016 at 10:38:55AM -0700, Stephen Hemminger wrote: > On Fri, 26 Aug 2016 12:17:37 +0100 > Ferruh Yigit wrote: > > > No new feature added, code refactored. > > > > Ferruh Yigit (22): > > net/pcap: convert config option to a macro > > net/pcap: use macros for param string > > net/pcap: reorganize private structs > > net/pcap: add checks for max queue number > > net/pcap: update function to reuse it > > net/pcap: don't carry numa_node argument > > net/pcap: don't carry kvlist argument > > net/pcap: move comment to correct place > > net/pcap: remove duplicated max queue number check > > net/pcap: use single_iface variable instead of hardcoded > > net/pcap: group stats related fields into a struct > > net/pcap: make const array static > > net/pcap: reorder header files > > net/pcap: reorder functions > > net/pcap: update how single iface handled > > net/pcap: remove unnecessary check > > net/pcap: remove redundant assignment > > net/pcap: simplify function > > net/pcap: fix missing Tx iface assignment > > net/pcap: coding convention updates > > net/pcap: remove rte prefix from static functions > > net/pcap: fix checkpatch warnings > > > > drivers/net/pcap/rte_eth_pcap.c | 644 +++++++++++++++++++--------------------- > > 1 file changed, 309 insertions(+), 335 deletions(-) > > > > These all look like good ideas. Haven't tested this but they all are > simple changes. > > Acked-by: Stephen Hemminger Applied to dpdk-next-net/rel_16_11 /Bruce