From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx: fix compile errors with ignore pedantic pragma Date: Tue, 20 Sep 2016 14:51:27 +0200 Message-ID: <20160920125126.GG17252@6wind.com> References: <1474295814-4879-1-git-send-email-bruce.richardson@intel.com> <20160919145959.GB17252@6wind.com> <20160919152605.GG45548@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id D497D6CBB for ; Tue, 20 Sep 2016 14:51:33 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id l132so207591556wmf.0 for ; Tue, 20 Sep 2016 05:51:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160919152605.GG45548@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 19, 2016 at 04:26:05PM +0100, Bruce Richardson wrote: > On Mon, Sep 19, 2016 at 04:59:59PM +0200, Adrien Mazarguil wrote: > > Hi Bruce, > > > > On Mon, Sep 19, 2016 at 03:36:54PM +0100, Bruce Richardson wrote: > > > With recent gcc versions, e.g. gcc 6.1, compilation of mlx drivers with > > > debug enabled produces lots of errors complaining that "pedantic" is > > > not a warning level that can be ignored. > > > > > > error: ‘-pedantic’ is not an option that controls warnings [-Werror=pragmas] > > > #pragma GCC diagnostic ignored "-pedantic" > > > ^~~~~~~~~~~ > > > > > > These errors can be removed by changing the "-pedantic" to "-Wpedantic". > > > > Nice to have a workaround, I thought they did not keep the option at all. > > However after testing: > > > > - It does not seem to work with GCC 4.6 and older, they prefer -pedantic: > > "warning: unknown option after `#pragma GCC diagnostic' kind". > > > > - GCC 4.9 (possibly 5.x as well) does not care, can use either -pedantic or > > -Wpedantic. > > > > - GCC 6 can only supports -Wpedantic. > > > > Note we're working toward removing the need for these #pragma in the first > > place as soon as possible, however in the meantime I fear that checking the > > GCC version is necessary. > > > Depends on how old of GCC version we need to support. From the release notes > it appears that -Wpedantic was introduced in GCC 4.8 (3 1/2 years ago). > > https://gcc.gnu.org/gcc-4.8/changes.html > > Do we need to support compilation on gcc versions older than this? I'm all for upgrading so I do not really mind if we stop caring about older GCC versions (especially considering this problem only occurs in debugging mode which is seldom used by non-developers). The version check is necessary if we want to keep full compatibility with at least: - RHEL <= 6.x - Debian <= 7.x - Ubuntu <= 13.04 Works for me either way, thus: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND