From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2] vhost: Add indirect descriptors support
	to the TX path
Date: Fri, 23 Sep 2016 15:29:15 +0800
Message-ID: <20160923072915.GW23158@yliu-dev.sh.intel.com>
References: <1474615009-26626-1-git-send-email-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: huawei.xie@intel.com, dev@dpdk.org, vkaplans@redhat.com, mst@redhat.com,
 stephen@networkplumber.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id D3A535688
 for <dev@dpdk.org>; Fri, 23 Sep 2016 09:28:49 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1474615009-26626-1-git-send-email-maxime.coquelin@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Sep 23, 2016 at 09:16:49AM +0200, Maxime Coquelin wrote:
> +		if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) {
> +			if (unlikely(!(dev->features &
> +					(1ULL << VIRTIO_RING_F_INDIRECT_DESC)))) {
> +				RTE_LOG(ERR, VHOST_DATA,
> +						"Indirect desc but feature not negotiated.\n");
> +				break;
> +			}

I thought the alignment we got before was to follow linux kernel: check
nested indirect only?

> +
> +			desc = (struct vring_desc *)gpa_to_vva(dev,
> +					vq->desc[desc_indexes[i]].addr);

I think we should check the desc addr here. Otherwise we may crash here
if a malicious guest fills some bad addresses.

	--yliu