From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2] scripts: add more git log checks
Date: Mon, 26 Sep 2016 11:26:01 +0800
Message-ID: <20160926032601.GI23158@yliu-dev.sh.intel.com>
References: <20160920085303.24631-1-ferruh.yigit@intel.com>
 <20160923124727.30356-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 65F702BA1
 for <dev@dpdk.org>; Mon, 26 Sep 2016 05:25:36 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160923124727.30356-1-ferruh.yigit@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Sep 23, 2016 at 01:47:27PM +0100, Ferruh Yigit wrote:
> Alphabetically sorted items to check and
> added git log capitalization checks for LRO, NIC and PMD
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  scripts/check-git-log.sh | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
> index 1e05cf2..5f8a9fc 100755
> --- a/scripts/check-git-log.sh
> +++ b/scripts/check-git-log.sh
> @@ -112,20 +112,23 @@ bad=$(echo "$headlines" | grep -E --color=always \
>  	-e '\<[hsf]w\>' \
>  	-e '\<l[234]\>' \
>  	-e ':.*\<api\>' \
> +	-e ':.*\<arm\>' \
> +	-e ':.*\<armv7\>' \
> +	-e ':.*\<armv8\>' \
>  	-e ':.*\<dma\>' \
> -	-e ':.*\<pci\>' \
> -	-e ':.*\<mtu\>' \
> +	-e ':.*\<freebsd\>' \
> +	-e ':.*\<linux\>' \
> +	-e ':.*\<lro\>' \
>  	-e ':.*\<mac\>' \
> +	-e ':.*\<mtu\>' \
> +	-e ':.*\<nic\>' \
>  	-e ':.*\<numa\>' \
> -	-e ':.*\<vlan\>' \
> +	-e ':.*\<pci\>' \
> +	-e ':.*\<pmd\>' \
>  	-e ':.*\<rss\>' \
> -	-e ':.*\<freebsd\>' \
> -	-e ':.*\<linux\>' \
> -	-e ':.*\<tilegx\>' \
>  	-e ':.*\<tile-gx\>' \
> -	-e ':.*\<arm\>' \
> -	-e ':.*\<armv7\>' \
> -	-e ':.*\<armv8\>' \
> +	-e ':.*\<tilegx\>' \
> +	-e ':.*\<vlan\>' \

That basically means to me that you should store this (long) list into a
file, with the help of "-f" option.

	--yliu

>  	| sed 's,^,\t,')
>  [ -z "$bad" ] || printf "Wrong headline lowercase:\n$bad\n"
>  
> -- 
> 2.7.4