From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3] vhost: Add indirect descriptors support
	to the TX path
Date: Tue, 27 Sep 2016 12:15:55 +0800
Message-ID: <20160927041555.GC25823@yliu-dev.sh.intel.com>
References: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: huawei.xie@intel.com, dev@dpdk.org, vkaplans@redhat.com, mst@redhat.com,
 stephen@networkplumber.org
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 23AFE2BB4
 for <dev@dpdk.org>; Tue, 27 Sep 2016 06:15:33 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1474619303-16709-1-git-send-email-maxime.coquelin@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Sep 23, 2016 at 10:28:23AM +0200, Maxime Coquelin wrote:
> +		if (vq->desc[desc_indexes[i]].flags & VRING_DESC_F_INDIRECT) {
> +			desc = (struct vring_desc *)gpa_to_vva(dev,

As mentioned before, this would break 32 bit OS build. It should be

	(struct vring_desc *)(uintptr_t)gpa_to_vva(...);

I meant to fix this while apply, later I just realized you haven't
updated the release note (sorry for the late notice).

So would you mind send a new version, with the fix and release note
update? FYI, the release note is at "doc/guides/rel_notes/"

	--yliu