From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v3] net: fix build error with clang
Date: Wed, 28 Sep 2016 08:09:08 +0800
Message-ID: <20160928000908.GB1597@yliu-dev.sh.intel.com>
References: <1474611309-20325-1-git-send-email-yuanhan.liu@linux.intel.com>
 <1474864153-11847-1-git-send-email-yuanhan.liu@linux.intel.com>
 <20160927121951.GP25823@yliu-dev.sh.intel.com>
 <4341B239C0EFF9468EE453F9E9F4604D3A384822@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 "Liang, Cunming" <cunming.liang@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Chen, Jing D" <jing.d.chen@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1F83A2BB5
 for <dev@dpdk.org>; Wed, 28 Sep 2016 02:08:34 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D3A384822@shsmsx102.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Sep 27, 2016 at 05:24:35PM +0000, Chen, Jing D wrote:
> > On Mon, Sep 26, 2016 at 12:29:13PM +0800, Yuanhan Liu wrote:
> > > Interestingly, clang and gcc has different prototype for _mm_prefetch().
> > > For gcc, we have
> > >
> > >    _mm_prefetch (const void *__P, enum _mm_hint __I)
> > >
> > > While for clang, it's
> > >
> > >    #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a), 0,
> > > (sel)))
> > >
> > > That's how the following error comes with clang:
> > >
> > >    error: cast from 'const void *' to 'void *' drops const qualifier
> > >    [-Werror,-Wcast-qual]
> > >            _mm_prefetch((const void *)rused, _MM_HINT_T0);
> > >    /usr/lib/llvm-3.8/bin/../lib/clang/3.8.0/include/xmmintrin.h:684:58:
> > >    note: expanded from macro '_mm_prefetch'
> > >             #define _mm_prefetch(a, sel) (__builtin_prefetch((void *)(a),
> > >                                           0, (sel)))
> > >
> > > What's weird is that the build was actaully Okay before. I met it
> > > while apply Jerin's vector support for ARM patch set: he just move
> > > this peiece of code to another file, nothing else changed.
> > >
> > > This patch fix the issue when Jerin's patchset is applied. Thus, I
> > > think it's still needed.
> > >
> > > Similarly, make the same change to other _mm_prefetch users, just in
> > > case this weird issue shows up again somehow later.
...
> > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Acked-by: Jing Chen <jing.d.chen@intel.com>

Mark, thank you!

Applied to dpdk-next-virtio.

	--yliu