From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH] pmdinfogen: fix clang build error Date: Wed, 28 Sep 2016 07:35:19 -0400 Message-ID: <20160928113519.GA28138@hmsreliant.think-freely.org> References: <20160928100519.14885-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id C516B5679 for ; Wed, 28 Sep 2016 13:35:31 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20160928100519.14885-1-ferruh.yigit@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote: > Compile error: > CC mlx5.o.pmd.o > mlx5.o.pmd.c:1:227: > error: no newline at end of file [-Werror,-Wnewline-eof] > ...__attribute__((used)) = "PMD_INFO_STRING= {...}"; > ^ > > Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG > config options enabled. > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") > > Signed-off-by: Ferruh Yigit > --- > buildtools/pmdinfogen/pmdinfogen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c > index e1bf2e4..59ab956 100644 > --- a/buildtools/pmdinfogen/pmdinfogen.c > +++ b/buildtools/pmdinfogen/pmdinfogen.c > @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile) > else > fprintf(ofd, " "); > } > - fprintf(ofd, "]}\";"); > + fprintf(ofd, "]}\";\n"); > drv = drv->next; > } > > -- > 2.7.4 > > What was the error this produced? It seems like a false positive to me to require a newline at the end of a string, and it certainly doesn't provide any benefit when pmdinfo reads it back later. Neil