From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Daley Subject: [PATCH 2/4] net/enic: fix segfault when restarting with fdir filters Date: Thu, 29 Sep 2016 13:56:37 -0700 Message-ID: <20160929205639.1175-2-johndale@cisco.com> References: <20160929205639.1175-1-johndale@cisco.com> Cc: dev@dpdk.org, John Daley To: bruce.richardson@intel.com Return-path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 3AE5529CD for ; Thu, 29 Sep 2016 22:56:59 +0200 (CEST) In-Reply-To: <20160929205639.1175-1-johndale@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When flow director filters where removed when an enic device is stopped, the filters were freed but the pointer was not set to NULL so the next stop would try to free them again. Fixes: fefed3d1e62c ("enic: new driver") Signed-off-by: John Daley --- drivers/net/enic/enic_clsf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c index b251b7f..111b194 100644 --- a/drivers/net/enic/enic_clsf.c +++ b/drivers/net/enic/enic_clsf.c @@ -240,6 +240,7 @@ void enic_clsf_destroy(struct enic *enic) vnic_dev_classifier(enic->vdev, CLSF_DEL, &key->fltr_id, NULL); rte_free(key); + enic->fdir.nodes[index] = NULL; } } -- 2.10.0