From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH] net/mlx5: fix Rx function selection
Date: Tue, 11 Oct 2016 17:01:36 +0200
Message-ID: <20161011150136.GP17252@6wind.com>
References: <7756139bfd1f3c3a610e0f1f8ccab3f27b62f6eb.1476191132.git.nelio.laranjeiro@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com
 [209.85.215.44]) by dpdk.org (Postfix) with ESMTP id 62B5E6CBE
 for <dev@dpdk.org>; Tue, 11 Oct 2016 17:01:44 +0200 (CEST)
Received: by mail-lf0-f44.google.com with SMTP id b81so44705812lfe.1
 for <dev@dpdk.org>; Tue, 11 Oct 2016 08:01:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <7756139bfd1f3c3a610e0f1f8ccab3f27b62f6eb.1476191132.git.nelio.laranjeiro@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 11, 2016 at 04:44:50PM +0200, Nelio Laranjeiro wrote:
> mlx5_rx_queue_setup() was setting the Rx function by itself instead of
> using priv_select_rx_function() written for that purpose.
> 
> Fixes: cdab90cb5c8d ("net/mlx5: add Tx/Rx burst function selection wrapper")
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

> ---
>  drivers/net/mlx5/mlx5_rxq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
> index b9a5fe6..fe27d22 100644
> --- a/drivers/net/mlx5/mlx5_rxq.c
> +++ b/drivers/net/mlx5/mlx5_rxq.c
> @@ -1264,7 +1264,7 @@ mlx5_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
>  		      (void *)dev, (void *)rxq_ctrl);
>  		(*priv->rxqs)[idx] = &rxq_ctrl->rxq;
>  		/* Update receive callback. */
> -		dev->rx_pkt_burst = mlx5_rx_burst;
> +		priv_select_rx_function(priv);
>  	}
>  	priv_unlock(priv);
>  	return -ret;
> -- 
> 2.1.4
> 

-- 
Adrien Mazarguil
6WIND