From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH] net/enic: update enic guide and add warning for invalid conf Date: Wed, 12 Oct 2016 17:19:34 +0100 Message-ID: <20161012161933.GH104428@bricha3-MOBL3> References: <20160929205505.31690-1-johndale@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: John Daley , "dev@dpdk.org" , Nelson Escobar To: "Mcnamara, John" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0E2F42935 for ; Wed, 12 Oct 2016 18:19:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 10, 2016 at 03:16:09PM +0100, Mcnamara, John wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley > > Sent: Thursday, September 29, 2016 9:55 PM > > To: Richardson, Bruce > > Cc: dev@dpdk.org; Nelson Escobar > > Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning > > for invalid conf > > > > From: Nelson Escobar > > > > Update the enic guide to better explain how to setup vNIC parameters on > > the Cisco VIC since the introduction of rx scatter and print an error > > message for the case of having 1 RQ configured in the vNIC. > > > > Signed-off-by: Nelson Escobar > > Hi, > > It would be better in the RST documentation to use ```` backticks to > designate function and variable names as fixed width. Also, the documentation > convention is to use Rx/Tx. However, these are minor so the patch is okay as > it is. > > Acked-by: John McNamara > Applied to dpdk-next-net/rel_16_11 as "document how to configure vNIC parameters" so as to make it clear that this is one logical change, rather than two - which would be implied by the use of "and" in the title. /Bruce