From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2 1/2] net/i40e: fix link status change interrupt Date: Tue, 25 Oct 2016 13:53:42 +0100 Message-ID: <20161025125341.GA57276@bricha3-MOBL3.ger.corp.intel.com> References: <1477369146-63317-1-git-send-email-qiming.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, jingjing.wu@intel.com, helin.zhang@intel.com To: Qiming Yang Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id C781C2E41 for ; Tue, 25 Oct 2016 14:53:45 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1477369146-63317-1-git-send-email-qiming.yang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 25, 2016 at 12:19:05PM +0800, Qiming Yang wrote: > Previously, link status interrupt in i40e is achieved by checking > LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only > for diagnostic use. Instead, drivers need to get the link status > change notification by using LSE (Link Status Event). > > This patch enables LSE and calls LSC callback when the event is > received. This patch also removes the processing on > LINK_STAT_CHANGE_MASK. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > Signed-off-by: Qiming Yang > --- Thanks for the V2. Unfortunately, this conflicts with some other changes to the driver, making the patch not apply cleanly, and a manual apply I tried did not compile successfully. Can you please do a V3 rebased on top of dpdk-next-net/rel_16_11. Thanks, /Bruce