From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix wrong use of vector instruction Date: Wed, 2 Nov 2016 16:56:03 +0100 Message-ID: <20161102155602.GF5733@6wind.com> References: <1477988007-26141-1-git-send-email-eladpe@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Elad Persiko Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id DF7342A5F for ; Wed, 2 Nov 2016 16:56:10 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n67so46330557wme.1 for ; Wed, 02 Nov 2016 08:56:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1477988007-26141-1-git-send-email-eladpe@mellanox.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 01, 2016 at 08:13:27AM +0000, Elad Persiko wrote: > Constraint alignment was not respected in Tx. > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Elad Persiko > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 21164ba..ba8e202 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -309,7 +309,7 @@ mlx5_tx_dbrec(struct txq *txq) > *txq->qp_db = htonl(txq->wqe_ci); > /* Ensure ordering between DB record and BF copy. */ > rte_wmb(); > - rte_mov16(dst, (uint8_t *)data); > + memcpy(dst, (uint8_t *)data, 16); > txq->bf_offset ^= (1 << txq->bf_buf_size); > } > > @@ -449,7 +449,7 @@ mlx5_tx_burst(void *dpdk_txq, struct rte_mbuf **pkts, uint16_t pkts_n) > wqe->eseg.mss = 0; > wqe->eseg.rsvd2 = 0; > /* Start by copying the Ethernet Header. */ > - rte_mov16((uint8_t *)raw, (uint8_t *)addr); > + memcpy((uint8_t *)raw, ((uint8_t *)addr), 16); > length -= MLX5_WQE_DWORD_SIZE; > addr += MLX5_WQE_DWORD_SIZE; > /* Replace the Ethernet type by the VLAN if necessary. */ > -- > 1.8.3.1 Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND