From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: Re: [PATCH] scripts: fix checkpatch from standard input Date: Mon, 28 Nov 2016 16:21:10 +0100 Message-ID: <20161128162110.23127b42@platinum> References: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-wj0-f171.google.com (mail-wj0-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id 1BB83201 for ; Mon, 28 Nov 2016 16:21:13 +0100 (CET) Received: by mail-wj0-f171.google.com with SMTP id mp19so119172308wjc.1 for ; Mon, 28 Nov 2016 07:21:13 -0800 (PST) In-Reply-To: <1479768161-6123-1-git-send-email-thomas.monjalon@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 21 Nov 2016 23:42:41 +0100, Thomas Monjalon wrote: > When checking a valid patch from standard input, > the footer lines of the report are not filtered out. > > The function check is called outside of any loop, > so the statement continue has no effect and the footer is printed. > > Fixes: 8005feef421d ("scripts: add standard input to checkpatch") > > Signed-off-by: Thomas Monjalon The 'continue' statement is not always without effect. On my machine (but it looks it's not the same everywhere): - with dash, the 'continue' acts like a return in that case - with bash, it displays an error: "continue: only meaningful in a `for', `while', or `until' loop" - with bash --posix, the 'continue' is ignored... In my case, checkpatches.sh was displaying "0/1 valid" although there was no error. This patch solves the issue, thanks. Acked-by: Olivier Matz