From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v3] eal/linuxapp: fix return value check of
	mknod()
Date: Tue, 6 Dec 2016 11:44:59 +0100
Message-ID: <20161206114459.0a05cbe0@platinum>
References: <1479264047-67966-1-git-send-email-wei.dai@intel.com>
 <1479365235-134903-1-git-send-email-wei.dai@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: david.marchand@6wind.com, dev@dpdk.org
To: Wei Dai <wei.dai@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f176.google.com (mail-wj0-f176.google.com
 [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id CAB7F2BAF
 for <dev@dpdk.org>; Tue,  6 Dec 2016 11:45:01 +0100 (CET)
Received: by mail-wj0-f176.google.com with SMTP id v7so315193142wjy.2
 for <dev@dpdk.org>; Tue, 06 Dec 2016 02:45:01 -0800 (PST)
In-Reply-To: <1479365235-134903-1-git-send-email-wei.dai@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Wei,

On Thu, 17 Nov 2016 14:47:15 +0800, Wei Dai <wei.dai@intel.com> wrote:
> In function pci_mknod_uio_dev() in lib/librte_eal/eal/eal_pci_uio.c,
> The return value of mknod() is ret, not f got by fopen().
> So the value of ret should be checked for mknod().
> 
> Fixes: f7f97c16048e ("pci: add option --create-uio-dev to run without
> hotplug")
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks