From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/3] net/e1000: optimize Rx/Tx log message
 level
Date: Tue, 6 Dec 2016 14:41:44 -0800
Message-ID: <20161206144144.1d68d40b@xeon-e3>
References: <1480761783-36467-1-git-send-email-qiming.yang@intel.com>
 <1480761783-36467-2-git-send-email-qiming.yang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Qiming Yang <qiming.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51])
 by dpdk.org (Postfix) with ESMTP id B20642BAF
 for <dev@dpdk.org>; Tue,  6 Dec 2016 23:41:52 +0100 (CET)
Received: by mail-pg0-f51.google.com with SMTP id p66so153961148pga.2
 for <dev@dpdk.org>; Tue, 06 Dec 2016 14:41:52 -0800 (PST)
In-Reply-To: <1480761783-36467-2-git-send-email-qiming.yang@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat,  3 Dec 2016 18:43:01 +0800
Qiming Yang <qiming.yang@intel.com> wrote:

>  
> +#ifdef RTE_LIBRTE_E1000_DEBUG_RX_FREE
> +#define PMD_RX_FREE_LOG(level, fmt, args...) \
> +	RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args)
> +#else
> +#define PMD_RX_FREE_LOG(level, fmt, args...) do { } while (0)
> +#endif

If you have to copy/paste same code in more than one driver, that
looks like a missing interface.  I.e Do not Repeat Yourself.