From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v12 0/6] add Tx preparation
Date: Wed, 7 Dec 2016 16:11:44 +0800
Message-ID: <20161207081144.GC31182@yliu-dev.sh.intel.com>
References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com>
 <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com>
 <8317180.L80Qf11uiu@xps13>
 <2dfc10d2-bb19-1385-aa01-97e44a3db139@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org,
 Jan Medala <jan@semihalf.com>, Jakub Palider <jpa@semihalf.com>,
 Netanel Belgazal <netanel@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Yong Wang <yongwang@vmware.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Tomasz Kulasek <tomaszx.kulasek@intel.com>, konstantin.ananyev@intel.com
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id D9BF72B96
 for <dev@dpdk.org>; Wed,  7 Dec 2016 09:11:02 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <2dfc10d2-bb19-1385-aa01-97e44a3db139@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Dec 06, 2016 at 03:53:42PM +0000, Ferruh Yigit wrote:
> > Please, we need a comment for each driver saying
> > "it is OK, we do not need any checksum preparation for TSO"
> > or
> > "yes we have to implement tx_prepare or TSO will not work in this mode"
> >

Sorry for late. For virtio, I think it's not a must. The checksum stuff
has been handled inside the Tx function. However, we may could move it
to tx_prepare, which would actually recover the performance lost
introduced while enabling TSO for the non-TSO case.

	--yliu