From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2 3/6] eventdev: implement the northbound
	APIs
Date: Wed, 7 Dec 2016 22:32:56 +0530
Message-ID: <20161207170256.GA4930@svelivela-lt.caveonetworks.com>
References: <1479447902-3700-2-git-send-email-jerin.jacob@caviumnetworks.com>
 <1480996340-29871-1-git-send-email-jerin.jacob@caviumnetworks.com>
 <1480996340-29871-4-git-send-email-jerin.jacob@caviumnetworks.com>
 <20161206171712.GC22224@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <hemant.agrawal@nxp.com>,
 <gage.eads@intel.com>, <harry.van.haaren@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0059.outbound.protection.outlook.com [104.47.41.59])
 by dpdk.org (Postfix) with ESMTP id A9CE82B8E
 for <dev@dpdk.org>; Wed,  7 Dec 2016 18:03:46 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20161206171712.GC22224@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Dec 06, 2016 at 05:17:12PM +0000, Bruce Richardson wrote:
> On Tue, Dec 06, 2016 at 09:22:17AM +0530, Jerin Jacob wrote:
> > This patch implements northbound eventdev API interface using
> > southbond driver interface
> > 
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> > +		/* Re allocate memory to store queue priority */
> > +		queues_prio = dev->data->queues_prio;
> > +		queues_prio = rte_realloc(queues_prio,
> > +				sizeof(queues_prio[0]) * nb_queues,
> > +				RTE_CACHE_LINE_SIZE);
> > +		if (queues_prio == NULL) {
> > +			RTE_EDEV_LOG_ERR("failed to realloc queue priority,"
> > +						" nb_queues %u", nb_queues);
> > +			return -(ENOMEM);
> > +		}
> > +		dev->data->queues_prio = queues_prio;
> > +
> > +		if (nb_queues > old_nb_queues) {
> > +			uint8_t new_qs = nb_queues - old_nb_queues;
> > +
> > +			memset(queues + old_nb_queues, 0,
> > +				sizeof(queues[0]) * new_qs);
> > +			memset(queues_prio + old_nb_queues, 0,
> > +				sizeof(queues_prio[0]) * new_qs);
> > +		}
> > +	} else if (dev->data->queues != NULL && nb_queues == 0) {
> > +		RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->queue_release, -ENOTSUP);
> > +
> > +		queues = dev->data->queues;
> > +		for (i = nb_queues; i < old_nb_queues; i++)
> > +			(*dev->dev_ops->queue_release)(queues[i]);
> > +	}
> > +
> > +	dev->data->nb_queues = nb_queues;
> > +	return 0;
> > +}
> > +
> While the ports array makes sense to have available at the top level of
> the API and allocated from rte_eventdev.c, I'm not seeing what the value
> of having the queues allocated at that level is. The only time the queue
> array is indexed by eventdev layer is when releasing a queue. Therefore,
> I suggest just saving the number of queues for sanity checking and let
> the queue array allocation and freeing be handled entirely in the
> drivers themselves.

I thought it would be useful for other drivers. I agree, If something is not
common across all the driver lets remove it from common code.
I will remove it in v3

> 
> /Bruce