dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Yi Zhang <zhang.yi75@zte.com.cn>
Cc: Helin Zhang <helin.zhang@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	dev@dpdk.org
Subject: Re: [PATCH v3] net/ixgbe:fix max packet length in ixgbevf
Date: Wed, 14 Dec 2016 15:06:21 +0800	[thread overview]
Message-ID: <20161214070621.GJ18991@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20161214185019.19581-1-zhang.yi75@zte.com.cn>

On Thu, Dec 15, 2016 at 02:50:19AM +0800, Yi Zhang wrote:
> Current ixgbevf driver get max_rx_pktlen = 15872, but in fact PF
> supports 15872-byte jumbo frame and VF only supports 9728-byte jumbo
> frame. If VF is running DPDK driver and set frame_size > 9728 ,PF
> running kernel ixgbe driver will report an error and set VF failed.
> This patch fixs DPDK ixgbevf driver to get correct jumbo frame size
> of VF.
> 
> Signed-off-by: Yi Zhang <zhang.yi75@zte.com.cn>

Hi,

I saw you have sent this patch 3 times; are you looking for review?
If so, you should not resend it many times, instead, you could reply
to your patch if it hasn't got any comments after one week, with
something like "some one can help review this?", or even a simple
"ping ..." might just work.

Besides that, you should Cc the corresponding maintainers, but not
"maintainer@some.org", which is just an example: I doubt such email
exists.

You could get the maintainers from the MAINTAINERS. Take ixgbe as
example, it's:

    Intel ixgbe
    M: Helin Zhang <helin.zhang@intel.com>
    M: Konstantin Ananyev <konstantin.ananyev@intel.com>
    F: drivers/net/ixgbe/
    F: doc/guides/nics/ixgbe.rst
    F: doc/guides/nics/intel_vf.rst

So for this patch, you should at least Cc (or To) Helin and Konstantin.
I have done that for you this time.

	--yliu
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index edc9b22..573252c 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3168,7 +3168,7 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
>  	dev_info->max_rx_queues = (uint16_t)hw->mac.max_rx_queues;
>  	dev_info->max_tx_queues = (uint16_t)hw->mac.max_tx_queues;
>  	dev_info->min_rx_bufsize = 1024; /* cf BSIZEPACKET in SRRCTL reg */
> -	dev_info->max_rx_pktlen = 15872; /* includes CRC, cf MAXFRS reg */
> +	dev_info->max_rx_pktlen = 9728; /* includes CRC, cf MAXFRS reg */
>  	dev_info->max_mac_addrs = hw->mac.num_rar_entries;
>  	dev_info->max_hash_mac_addrs = IXGBE_VMDQ_NUM_UC_MAC;
>  	dev_info->max_vfs = dev->pci_dev->max_vfs;
> -- 
> 2.9.3
> 

  reply	other threads:[~2016-12-14  7:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 18:50 [PATCH v3] net/ixgbe:fix max packet length in ixgbevf Yi Zhang
2016-12-14  7:06 ` Yuanhan Liu [this message]
2017-01-25  1:39   ` Dai, Wei
2017-01-25  1:42     ` Dai, Wei
2017-01-25 14:40       ` Ferruh Yigit
2017-01-25  1:21 ` Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161214070621.GJ18991@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=zhang.yi75@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).