From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH 12/22] app/testpmd: add rte_flow item spec handler Date: Fri, 16 Dec 2016 16:25:25 +0100 Message-ID: <20161216152525.GF10340@6wind.com> References: <2d37e8ee1c613557e94acef94e381b72b2a535ce.1479309720.git.adrien.mazarguil@6wind.com> <188971FCDA171749BED5DA74ABF3E6F03B6625B9@shsmsx102.ccr.corp.intel.com> <20161216091746.GC10340@6wind.com> <94479800C636CB44BD422CB454846E01315717A4@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Pei, Yulong" , "dev@dpdk.org" , Thomas Monjalon , "De Lara Guarch, Pablo" , Olivier Matz To: "Xing, Beilei" Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 30E1758EC for ; Fri, 16 Dec 2016 16:25:34 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id a197so36910596wmd.0 for ; Fri, 16 Dec 2016 07:25:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <94479800C636CB44BD422CB454846E01315717A4@SHSMSX101.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei, On Fri, Dec 16, 2016 at 12:22:52PM +0000, Xing, Beilei wrote: > Thanks Adrien. > > I have two questions: > 1. when I set " / vlan tci fix 10" with testpmd, I find the mask of tci is 0xFFFF. > Actually tci includes PRI, CFI, and Vlan_id which holds 12 bits, so is it possible > to set the mask to 0xFFF? > Our driver will check the mask only covers vlan_id instead of the whole tci. Right, I'll work on a method to do that. TCI remains 16 bit either way so the current approach remains accurate, although not convenient because a 10 bit mask must be specified manually. This change won't be included in v2 though. > 2. When we test destroy function, we find the pointer provided to PMD is NULL > instead of the pointer PMD returned to RTE during creating flow. Could you > please have double check? Thanks. There is indeed a bug [1]. It is fixed in v2. Thanks. [1] http://dpdk.org/ml/archives/dev/2016-November/050435.html -- Adrien Mazarguil 6WIND