From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] net/af_packet: initialize link interrupt callback queue Date: Sat, 17 Dec 2016 15:32:00 -0800 Message-ID: <20161217153200.4d05d711@xeon-e3> References: <1481997835-23288-1-git-send-email-3chas3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Chas Williams <3chas3@gmail.com> Return-path: Received: from mail-pg0-f48.google.com (mail-pg0-f48.google.com [74.125.83.48]) by dpdk.org (Postfix) with ESMTP id AC3282BA8 for ; Sun, 18 Dec 2016 00:32:08 +0100 (CET) Received: by mail-pg0-f48.google.com with SMTP id a1so23448361pgf.1 for ; Sat, 17 Dec 2016 15:32:08 -0800 (PST) In-Reply-To: <1481997835-23288-1-git-send-email-3chas3@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 17 Dec 2016 13:03:55 -0500 Chas Williams <3chas3@gmail.com> wrote: > This patch initializes the eth_dev->link_intr_cbs queue which is > used when af_packet is passed into rte_eth_ev_callback_register(). > > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") > > Signed-off-by: Chas Williams <3chas3@gmail.com> > --- > drivers/net/af_packet/rte_eth_af_packet.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index a1e13ff..ea5070a 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name, > (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name; > (*eth_dev)->data->kdrv = RTE_KDRV_NONE; > (*eth_dev)->data->numa_node = numa_node; > + TAILQ_INIT(&((*eth_dev)->link_intr_cbs)); This code really needs to have a local variable for eth_dev and not deref a pointer in every statement.