From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v3 2/6] eventdev: define southbound driver interface Date: Mon, 19 Dec 2016 15:50:07 +0000 Message-ID: <20161219155006.GA166228@bricha3-MOBL3.ger.corp.intel.com> References: <1480798539-13360-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482070895-32491-1-git-send-email-jerin.jacob@caviumnetworks.com> <1482070895-32491-3-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, thomas.monjalon@6wind.com, hemant.agrawal@nxp.com, gage.eads@intel.com, harry.van.haaren@intel.com To: Jerin Jacob Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8ED6AFA52 for ; Mon, 19 Dec 2016 16:50:11 +0100 (CET) Content-Disposition: inline In-Reply-To: <1482070895-32491-3-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 18, 2016 at 07:51:31PM +0530, Jerin Jacob wrote: > Signed-off-by: Jerin Jacob > --- > lib/librte_eventdev/rte_eventdev.h | 38 +++++ > lib/librte_eventdev/rte_eventdev_pmd.h | 291 +++++++++++++++++++++++++++++++++ > 2 files changed, 329 insertions(+) > create mode 100644 lib/librte_eventdev/rte_eventdev_pmd.h > > + > +/** > + * Release resources allocated by given event queue. > + * > + * @param queue_id > + * Event queue index > + * > + */ > +typedef void (*eventdev_queue_release_t)(uint8_t queue_id); > + Missing an eventdev pointer here too, otherwise you can't use the queue index to find the queue. /Bruce