From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v5 03/20] rte_device: make driver pointer const Date: Fri, 23 Dec 2016 14:08:28 -0800 Message-ID: <20161223140828.2232d1c8@xeon-e3> References: <1482508691-11408-1-git-send-email-jblunck@infradead.org> <1482508691-11408-4-git-send-email-jblunck@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, shreyansh.jain@nxp.com, david.marchand@6wind.com To: Jan Blunck Return-path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id AC80E2B86 for ; Fri, 23 Dec 2016 23:08:37 +0100 (CET) Received: by mail-pf0-f173.google.com with SMTP id i88so45393234pfk.2 for ; Fri, 23 Dec 2016 14:08:37 -0800 (PST) In-Reply-To: <1482508691-11408-4-git-send-email-jblunck@infradead.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 23 Dec 2016 16:57:54 +0100 Jan Blunck wrote: > From: Stephen Hemminger > > The info in rte_device about driver is immutable and > shouldn't change. > > Acked-by: Jan Blunck > Acked-by: Shreyansh Jain > --- > lib/librte_eal/common/include/rte_dev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h > index 1708244..b17791f 100644 > --- a/lib/librte_eal/common/include/rte_dev.h > +++ b/lib/librte_eal/common/include/rte_dev.h > @@ -122,7 +122,7 @@ struct rte_driver; > */ > struct rte_device { > TAILQ_ENTRY(rte_device) next; /**< Next device */ > - struct rte_driver *driver; /**< Associated driver */ > + const struct rte_driver *driver;/**< Associated driver */ > int numa_node; /**< NUMA node connection */ > struct rte_devargs *devargs; /**< Device user arguments */ > }; Go ahead and add missing signed-off-by. I overlooked it on the original RFC set. Signed-off-by: Stephen Hemminger