From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] examples/l3fwd: fix validation for queue id of config tuple Date: Fri, 25 Mar 2016 19:49:10 +0100 Message-ID: <2016370.aLXS1Y04Ta@xps13> References: <1458861061-11211-1-git-send-email-reshma.pattan@intel.com> <1458918824-15168-1-git-send-email-reshma.pattan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Ananyev, Konstantin" To: "Pattan, Reshma" Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 144EB568B for ; Fri, 25 Mar 2016 19:50:57 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id l68so26201211wml.0 for ; Fri, 25 Mar 2016 11:50:57 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Added validation for queue id of config parameter tuple. > > > > This validation enforces user to enter queue ids of a port > > from 0 and in sequence. > > > > This additional validation on queue ids avoids ixgbe crash caused by null > > rxq pointer access inside ixgbe_dev_rx_init. > > > > Reason for null rxq is, L3fwd application allocates memory only for queues > > passed by user. > > But rte_eth_dev_start tries to initialize rx queues in sequence from 0 to > > nb_rx_queues, > > which is not true and coredump while accessing the unallocated queue . > > > > Fixes: af75078fece3 ("first public release") > > > > Signed-off-by: Reshma Pattan > > Acked-by: Pablo de Lara Applied, thanks